Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve and speed up channelz keepalive test #6556

Merged
merged 1 commit into from
Aug 16, 2023
Merged

test: improve and speed up channelz keepalive test #6556

merged 1 commit into from
Aug 16, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 15, 2023 •
edited
Loading

RELEASE NOTES: none

@dfawley dfawley added this to the 1.58 Release milestone Aug 15, 2023
@dfawley dfawley requested a review from arvindbr8 August 15, 2023 23:08
arvindbr8
arvindbr8 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!
seems like this is should shave off ~3.5 sec. Maybe we dont have to end up splitting tests from test package.

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Aug 16, 2023
@dfawley dfawley merged commit e5d8eac into grpc:master Aug 16, 2023
1 check passed
@dfawley dfawley deleted the czkeeptest branch August 16, 2023 15:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Testing
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8